Skip to content

Commit

Permalink
sh: define DMA slaves per CPU type, remove now redundant header
Browse files Browse the repository at this point in the history
Now that DMA slave IDs are only used used in platform specific code and have
become opaque cookies for the rest of the code, we can make the, CPU specific
too.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
Signed-off-by: Paul Mundt <[email protected]>
  • Loading branch information
lyakh authored and pmundt committed May 22, 2010
1 parent 2d15124 commit 10440af
Show file tree
Hide file tree
Showing 10 changed files with 42 additions and 48 deletions.
34 changes: 0 additions & 34 deletions arch/sh/include/asm/dmaengine.h

This file was deleted.

2 changes: 0 additions & 2 deletions arch/sh/include/asm/siu.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
#ifndef ASM_SIU_H
#define ASM_SIU_H

#include <asm/dmaengine.h>

struct device;

struct siu_platform {
Expand Down
15 changes: 15 additions & 0 deletions arch/sh/include/cpu-sh4/cpu/sh7722.h
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,19 @@ enum {
HWBLK_NR,
};

enum {
SHDMA_SLAVE_SCIF0_TX,
SHDMA_SLAVE_SCIF0_RX,
SHDMA_SLAVE_SCIF1_TX,
SHDMA_SLAVE_SCIF1_RX,
SHDMA_SLAVE_SCIF2_TX,
SHDMA_SLAVE_SCIF2_RX,
SHDMA_SLAVE_SIUA_TX,
SHDMA_SLAVE_SIUA_RX,
SHDMA_SLAVE_SIUB_TX,
SHDMA_SLAVE_SIUB_RX,
SHDMA_SLAVE_SDHI0_TX,
SHDMA_SLAVE_SDHI0_RX,
};

#endif /* __ASM_SH7722_H__ */
19 changes: 19 additions & 0 deletions arch/sh/include/cpu-sh4/cpu/sh7724.h
Original file line number Diff line number Diff line change
Expand Up @@ -283,4 +283,23 @@ enum {
HWBLK_NR,
};

enum {
SHDMA_SLAVE_SCIF0_TX,
SHDMA_SLAVE_SCIF0_RX,
SHDMA_SLAVE_SCIF1_TX,
SHDMA_SLAVE_SCIF1_RX,
SHDMA_SLAVE_SCIF2_TX,
SHDMA_SLAVE_SCIF2_RX,
SHDMA_SLAVE_SCIF3_TX,
SHDMA_SLAVE_SCIF3_RX,
SHDMA_SLAVE_SCIF4_TX,
SHDMA_SLAVE_SCIF4_RX,
SHDMA_SLAVE_SCIF5_TX,
SHDMA_SLAVE_SCIF5_RX,
SHDMA_SLAVE_SDHI0_TX,
SHDMA_SLAVE_SDHI0_RX,
SHDMA_SLAVE_SDHI1_TX,
SHDMA_SLAVE_SDHI1_RX,
};

#endif /* __ASM_SH7724_H__ */
1 change: 0 additions & 1 deletion arch/sh/kernel/cpu/sh4a/setup-sh7722.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <linux/usb/m66592.h>

#include <asm/clock.h>
#include <asm/dmaengine.h>
#include <asm/mmzone.h>
#include <asm/siu.h>

Expand Down
2 changes: 1 addition & 1 deletion arch/sh/kernel/cpu/sh4a/setup-sh7724.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
#include <linux/mm.h>
#include <linux/serial_sci.h>
#include <linux/uio_driver.h>
#include <linux/sh_dma.h>
#include <linux/sh_timer.h>
#include <linux/io.h>
#include <linux/notifier.h>

#include <asm/suspend.h>
#include <asm/clock.h>
#include <asm/dmaengine.h>
#include <asm/mmzone.h>

#include <cpu/dma-register.h>
Expand Down
3 changes: 1 addition & 2 deletions arch/sh/kernel/cpu/sh4a/setup-sh7780.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@
#include <linux/serial.h>
#include <linux/io.h>
#include <linux/serial_sci.h>
#include <linux/sh_dma.h>
#include <linux/sh_timer.h>

#include <asm/dmaengine.h>

#include <cpu/dma-register.h>

static struct plat_sci_port scif0_platform_data = {
Expand Down
2 changes: 1 addition & 1 deletion arch/sh/kernel/cpu/sh4a/setup-sh7785.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#include <linux/serial_sci.h>
#include <linux/io.h>
#include <linux/mm.h>
#include <linux/sh_dma.h>
#include <linux/sh_timer.h>

#include <asm/dmaengine.h>
#include <asm/mmzone.h>

#include <cpu/dma-register.h>
Expand Down
3 changes: 1 addition & 2 deletions sound/soc/sh/siu.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ struct siu_firmware {
#include <linux/dmaengine.h>
#include <linux/interrupt.h>
#include <linux/io.h>

#include <asm/dmaengine.h>
#include <linux/sh_dma.h>

#include <sound/core.h>
#include <sound/pcm.h>
Expand Down
9 changes: 4 additions & 5 deletions sound/soc/sh/siu_pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include <sound/pcm_params.h>
#include <sound/soc-dai.h>

#include <asm/dmaengine.h>
#include <asm/siu.h>

#include "siu.h"
Expand Down Expand Up @@ -358,13 +357,13 @@ static int siu_pcm_open(struct snd_pcm_substream *ss)
if (ss->stream == SNDRV_PCM_STREAM_PLAYBACK) {
siu_stream = &port_info->playback;
param = &siu_stream->param;
param->slave_id = port ? SHDMA_SLAVE_SIUB_TX :
SHDMA_SLAVE_SIUA_TX;
param->slave_id = port ? pdata->dma_slave_tx_b :
pdata->dma_slave_tx_a;
} else {
siu_stream = &port_info->capture;
param = &siu_stream->param;
param->slave_id = port ? SHDMA_SLAVE_SIUB_RX :
SHDMA_SLAVE_SIUA_RX;
param->slave_id = port ? pdata->dma_slave_rx_b :
pdata->dma_slave_rx_a;
}

param->dma_dev = pdata->dma_dev;
Expand Down

0 comments on commit 10440af

Please sign in to comment.