Skip to content

Commit

Permalink
jbd2: remove pointless assertion in __journal_remove_journal_head
Browse files Browse the repository at this point in the history
Only when jh->b_jcount = 0 in jbd2_journal_put_journal_head, we are allowed
to call __journal_remove_journal_head. This assertion is meaningless,
just remove it.

Signed-off-by: Shijie Luo <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
  • Loading branch information
Shijie Luo authored and tytso committed Jan 25, 2020
1 parent 8d6ce13 commit 17c51d8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/jbd2/journal.c
Original file line number Diff line number Diff line change
Expand Up @@ -2560,7 +2560,6 @@ static void __journal_remove_journal_head(struct buffer_head *bh)
{
struct journal_head *jh = bh2jh(bh);

J_ASSERT_JH(jh, jh->b_jcount >= 0);
J_ASSERT_JH(jh, jh->b_transaction == NULL);
J_ASSERT_JH(jh, jh->b_next_transaction == NULL);
J_ASSERT_JH(jh, jh->b_cp_transaction == NULL);
Expand Down

0 comments on commit 17c51d8

Please sign in to comment.