iio: light: si1133 fix test for val being not zero or not one.

The current check on val always results in true and so the call to sii1133_update_adcsens never gets called. Fix this check so it returns with -EINVAL only when val is not zero and not one. Detected by CoverityScan, CID#1472099 ("Logically dead code") Fixes: e01e7ea ("iio: light: introduce si1133") Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
ambv · Jul 30, 2018 · 1e96e93 · 1e96e93
1 parent 9a5094c
commit 1e96e93
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
@@ -838,7 +838,7 @@ static int si1133_write_raw(struct iio_dev *iio_dev,
 		switch (chan->type) {
 		case IIO_INTENSITY:
 		case IIO_UVINDEX:
-			if (val != 0 || val != 1)
+			if (val != 0 && val != 1)
 				return -EINVAL;
 
 			return si1133_update_adcsens(data,