Skip to content

Commit

Permalink
mm/hmm: add helpers to test if mm is still alive or not
Browse files Browse the repository at this point in the history
The device driver can have kernel thread or worker doing work against a
process mm and it is useful for those to test wether the mm is dead or
alive to avoid doing useless work.  Add an helper to test that so that
driver can bail out early if a process is dying.

Note that the helper does not perform any lock synchronization and thus is
just a hint ie a process might be dying but the helper might still return
the process as alive.  All HMM functions are safe to use in that case as
HMM internal properly protect itself with lock.  If driver use this helper
with non HMM functions it should ascertain that it is safe to do so.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Jérôme Glisse <[email protected]>
Cc: Ralph Campbell <[email protected]>
Cc: John Hubbard <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Ira Weiny <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Balbir Singh <[email protected]>
Cc: Dan Carpenter <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Souptick Joarder <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Jérôme Glisse authored and torvalds committed May 14, 2019
1 parent 992de9a commit 2023941
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions include/linux/hmm.h
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,30 @@ struct hmm_mirror {
int hmm_mirror_register(struct hmm_mirror *mirror, struct mm_struct *mm);
void hmm_mirror_unregister(struct hmm_mirror *mirror);

/*
* hmm_mirror_mm_is_alive() - test if mm is still alive
* @mirror: the HMM mm mirror for which we want to lock the mmap_sem
* Returns: false if the mm is dead, true otherwise
*
* This is an optimization it will not accurately always return -EINVAL if the
* mm is dead ie there can be false negative (process is being kill but HMM is
* not yet inform of that). It is only intented to be use to optimize out case
* where driver is about to do something time consuming and it would be better
* to skip it if the mm is dead.
*/
static inline bool hmm_mirror_mm_is_alive(struct hmm_mirror *mirror)
{
struct mm_struct *mm;

if (!mirror || !mirror->hmm)
return false;
mm = READ_ONCE(mirror->hmm->mm);
if (mirror->hmm->dead || !mm)
return false;

return true;
}


/*
* Please see Documentation/vm/hmm.rst for how to use the range API.
Expand Down

0 comments on commit 2023941

Please sign in to comment.