Skip to content

Commit

Permalink
ipv6: send only one NEWLINK when RA causes changes
Browse files Browse the repository at this point in the history
Signed-off-by: Marius Tomaschewski <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
mtomaschewski authored and davem330 committed Sep 1, 2015
1 parent c42858e commit 2053aeb
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions net/ipv6/ndisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,7 @@ static void ndisc_router_discovery(struct sk_buff *skb)
int optlen;
unsigned int pref = 0;
__u32 old_if_flags;
bool send_ifinfo_notify = false;

__u8 *opt = (__u8 *)(ra_msg + 1);

Expand Down Expand Up @@ -1158,7 +1159,7 @@ static void ndisc_router_discovery(struct sk_buff *skb)
IF_RA_OTHERCONF : 0);

if (old_if_flags != in6_dev->if_flags)
inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
send_ifinfo_notify = true;

if (!in6_dev->cnf.accept_ra_defrtr) {
ND_PRINTK(2, info,
Expand Down Expand Up @@ -1261,7 +1262,7 @@ static void ndisc_router_discovery(struct sk_buff *skb)
rtime = HZ/10;
NEIGH_VAR_SET(in6_dev->nd_parms, RETRANS_TIME, rtime);
in6_dev->tstamp = jiffies;
inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
send_ifinfo_notify = true;
}

rtime = ntohl(ra_msg->reachable_time);
Expand All @@ -1278,11 +1279,17 @@ static void ndisc_router_discovery(struct sk_buff *skb)
GC_STALETIME, 3 * rtime);
in6_dev->nd_parms->reachable_time = neigh_rand_reach_time(rtime);
in6_dev->tstamp = jiffies;
inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);
send_ifinfo_notify = true;
}
}
}

/*
* Send a notify if RA changed managed/otherconf flags or timer settings
*/
if (send_ifinfo_notify)
inet6_ifinfo_notify(RTM_NEWLINK, in6_dev);

skip_linkparms:

/*
Expand Down

0 comments on commit 2053aeb

Please sign in to comment.