Skip to content

Commit

Permalink
9p: v9fs_vfs_rename incorrect clunk order
Browse files Browse the repository at this point in the history
In v9fs_vfs_rename function labels don't match the fids that are clunked.
The correct clunk order is clunking newdirfid first and then olddirfid next.

Signed-off-by: Latchesar Ionkov <[email protected]>
Signed-off-by: Eric Van Hensbergen <[email protected]>
  • Loading branch information
lionkov authored and ericvh committed Oct 23, 2007
1 parent 0a97629 commit 22150c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/9p/vfs_inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -687,10 +687,10 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
retval = p9_client_wstat(oldfid, &wstat);

clunk_newdir:
p9_client_clunk(olddirfid);
p9_client_clunk(newdirfid);

clunk_olddir:
p9_client_clunk(newdirfid);
p9_client_clunk(olddirfid);

done:
return retval;
Expand Down

0 comments on commit 22150c4

Please sign in to comment.