ALSA: firewire-tascam: handle error code when getting current source …

…of clock The return value of snd_tscm_stream_get_clock() is ignored. This commit checks the value and handle error. Fixes: e453df4 ("ALSA: firewire-tascam: add PCM functionality") Cc: <[email protected]> # v4.4+ Signed-off-by: Takashi Sakamoto <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
ambv · Sep 10, 2019 · 2617120 · 2617120
1 parent 2a36c16
commit 2617120
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/sound/firewire/tascam/tascam-pcm.c b/sound/firewire/tascam/tascam-pcm.c
@@ -56,6 +56,9 @@ static int pcm_open(struct snd_pcm_substream *substream)
 		goto err_locked;
 
 	err = snd_tscm_stream_get_clock(tscm, &clock);
+	if (err < 0)
+		goto err_locked;
+
 	if (clock != SND_TSCM_CLOCK_INTERNAL ||
 	    amdtp_stream_pcm_running(&tscm->rx_stream) ||
 	    amdtp_stream_pcm_running(&tscm->tx_stream)) {