Skip to content

Commit

Permalink
parport: EXPORT_SYMBOL should follow function
Browse files Browse the repository at this point in the history
All symbols were exported at the end of the file but they are supposed
to be exported just after the function. And checkpatch was complaining
about it.

Signed-off-by: Sudip Mukherjee <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
sudipm-mukherjee authored and gregkh committed Jan 4, 2016
1 parent 657e24d commit 27c6db2
Showing 1 changed file with 13 additions and 16 deletions.
29 changes: 13 additions & 16 deletions drivers/parport/share.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ void parport_unregister_driver (struct parport_driver *drv)
}
mutex_unlock(&registration_lock);
}
EXPORT_SYMBOL(parport_unregister_driver);

static void free_port(struct device *dev)
{
Expand Down Expand Up @@ -378,6 +379,7 @@ struct parport *parport_get_port (struct parport *port)

return to_parport_dev(dev);
}
EXPORT_SYMBOL(parport_get_port);

void parport_del_port(struct parport *port)
{
Expand All @@ -398,6 +400,7 @@ void parport_put_port (struct parport *port)
{
put_device(&port->bus_dev);
}
EXPORT_SYMBOL(parport_put_port);

/**
* parport_register_port - register a parallel port
Expand Down Expand Up @@ -508,6 +511,7 @@ struct parport *parport_register_port(unsigned long base, int irq, int dma,

return tmp;
}
EXPORT_SYMBOL(parport_register_port);

/**
* parport_announce_port - tell device drivers about a parallel port
Expand Down Expand Up @@ -555,6 +559,7 @@ void parport_announce_port (struct parport *port)
}
mutex_unlock(&registration_lock);
}
EXPORT_SYMBOL(parport_announce_port);

/**
* parport_remove_port - deregister a parallel port
Expand Down Expand Up @@ -616,6 +621,7 @@ void parport_remove_port(struct parport *port)
parport_put_port(slave);
}
}
EXPORT_SYMBOL(parport_remove_port);

/**
* parport_register_device - register a device on a parallel port
Expand Down Expand Up @@ -810,6 +816,7 @@ parport_register_device(struct parport *port, const char *name,

return NULL;
}
EXPORT_SYMBOL(parport_register_device);

static void free_pardevice(struct device *dev)
{
Expand Down Expand Up @@ -1025,6 +1032,7 @@ void parport_unregister_device(struct pardevice *dev)
module_put(port->ops->owner);
parport_put_port (port);
}
EXPORT_SYMBOL(parport_unregister_device);

/**
* parport_find_number - find a parallel port by number
Expand Down Expand Up @@ -1055,6 +1063,7 @@ struct parport *parport_find_number (int number)
spin_unlock (&parportlist_lock);
return result;
}
EXPORT_SYMBOL(parport_find_number);

/**
* parport_find_base - find a parallel port by base address
Expand Down Expand Up @@ -1085,6 +1094,7 @@ struct parport *parport_find_base (unsigned long base)
spin_unlock (&parportlist_lock);
return result;
}
EXPORT_SYMBOL(parport_find_base);

/**
* parport_claim - claim access to a parallel port device
Expand Down Expand Up @@ -1197,6 +1207,7 @@ int parport_claim(struct pardevice *dev)
write_unlock_irqrestore (&port->cad_lock, flags);
return -EAGAIN;
}
EXPORT_SYMBOL(parport_claim);

/**
* parport_claim_or_block - claim access to a parallel port device
Expand Down Expand Up @@ -1259,6 +1270,7 @@ int parport_claim_or_block(struct pardevice *dev)
dev->waiting = 0;
return r;
}
EXPORT_SYMBOL(parport_claim_or_block);

/**
* parport_release - give up access to a parallel port device
Expand Down Expand Up @@ -1330,6 +1342,7 @@ void parport_release(struct pardevice *dev)
pd->wakeup(pd->private);
}
}
EXPORT_SYMBOL(parport_release);

irqreturn_t parport_irq_handler(int irq, void *dev_id)
{
Expand All @@ -1339,22 +1352,6 @@ irqreturn_t parport_irq_handler(int irq, void *dev_id)

return IRQ_HANDLED;
}

/* Exported symbols for modules. */

EXPORT_SYMBOL(parport_claim);
EXPORT_SYMBOL(parport_claim_or_block);
EXPORT_SYMBOL(parport_release);
EXPORT_SYMBOL(parport_register_port);
EXPORT_SYMBOL(parport_announce_port);
EXPORT_SYMBOL(parport_remove_port);
EXPORT_SYMBOL(parport_unregister_driver);
EXPORT_SYMBOL(parport_register_device);
EXPORT_SYMBOL(parport_unregister_device);
EXPORT_SYMBOL(parport_get_port);
EXPORT_SYMBOL(parport_put_port);
EXPORT_SYMBOL(parport_find_number);
EXPORT_SYMBOL(parport_find_base);
EXPORT_SYMBOL(parport_irq_handler);

MODULE_LICENSE("GPL");

0 comments on commit 27c6db2

Please sign in to comment.