NFS: Fix the return value in nfs_page_mkwrite()

Commit c2ec175 ("mm: page_mkwrite change prototype to match fault") exposed a bug in the NFS implementation of page_mkwrite. We should be returning 0 on success... Signed-off-by: Trond Myklebust <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
ambv · Apr 7, 2009 · 2b2ec75 · 2b2ec75
1 parent 8e2c4f2
commit 2b2ec75
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
@@ -516,8 +516,6 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
 		goto out_unlock;
 
 	ret = nfs_updatepage(filp, page, 0, pagelen);
-	if (ret == 0)
-		ret = pagelen;
 out_unlock:
 	unlock_page(page);
 	if (ret)