Skip to content

Commit

Permalink
jffs2: constify xattr_handler
Browse files Browse the repository at this point in the history
Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Stephen Hemminger authored and Al Viro committed May 21, 2010
1 parent 46e5876 commit 365f0cb
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions fs/jffs2/acl.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,15 +419,15 @@ static int jffs2_acl_setxattr(struct dentry *dentry, const char *name,
return rc;
}

struct xattr_handler jffs2_acl_access_xattr_handler = {
const struct xattr_handler jffs2_acl_access_xattr_handler = {
.prefix = POSIX_ACL_XATTR_ACCESS,
.flags = ACL_TYPE_DEFAULT,
.list = jffs2_acl_access_listxattr,
.get = jffs2_acl_getxattr,
.set = jffs2_acl_setxattr,
};

struct xattr_handler jffs2_acl_default_xattr_handler = {
const struct xattr_handler jffs2_acl_default_xattr_handler = {
.prefix = POSIX_ACL_XATTR_DEFAULT,
.flags = ACL_TYPE_DEFAULT,
.list = jffs2_acl_default_listxattr,
Expand Down
4 changes: 2 additions & 2 deletions fs/jffs2/acl.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ extern int jffs2_acl_chmod(struct inode *);
extern int jffs2_init_acl_pre(struct inode *, struct inode *, int *);
extern int jffs2_init_acl_post(struct inode *);

extern struct xattr_handler jffs2_acl_access_xattr_handler;
extern struct xattr_handler jffs2_acl_default_xattr_handler;
extern const struct xattr_handler jffs2_acl_access_xattr_handler;
extern const struct xattr_handler jffs2_acl_default_xattr_handler;

#else

Expand Down
2 changes: 1 addition & 1 deletion fs/jffs2/security.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ static size_t jffs2_security_listxattr(struct dentry *dentry, char *list,
return retlen;
}

struct xattr_handler jffs2_security_xattr_handler = {
const struct xattr_handler jffs2_security_xattr_handler = {
.prefix = XATTR_SECURITY_PREFIX,
.list = jffs2_security_listxattr,
.set = jffs2_security_setxattr,
Expand Down
8 changes: 4 additions & 4 deletions fs/jffs2/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ struct jffs2_xattr_datum *jffs2_setup_xattr_datum(struct jffs2_sb_info *c,
* do_jffs2_setxattr(inode, xprefix, xname, buffer, size, flags)
* is an implementation of setxattr handler on jffs2.
* -------------------------------------------------- */
struct xattr_handler *jffs2_xattr_handlers[] = {
const struct xattr_handler *jffs2_xattr_handlers[] = {
&jffs2_user_xattr_handler,
#ifdef CONFIG_JFFS2_FS_SECURITY
&jffs2_security_xattr_handler,
Expand All @@ -917,8 +917,8 @@ struct xattr_handler *jffs2_xattr_handlers[] = {
NULL
};

static struct xattr_handler *xprefix_to_handler(int xprefix) {
struct xattr_handler *ret;
static const struct xattr_handler *xprefix_to_handler(int xprefix) {
const struct xattr_handler *ret;

switch (xprefix) {
case JFFS2_XPREFIX_USER:
Expand Down Expand Up @@ -955,7 +955,7 @@ ssize_t jffs2_listxattr(struct dentry *dentry, char *buffer, size_t size)
struct jffs2_inode_cache *ic = f->inocache;
struct jffs2_xattr_ref *ref, **pref;
struct jffs2_xattr_datum *xd;
struct xattr_handler *xhandle;
const struct xattr_handler *xhandle;
ssize_t len, rc;
int retry = 0;

Expand Down
8 changes: 4 additions & 4 deletions fs/jffs2/xattr.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ extern int do_jffs2_getxattr(struct inode *inode, int xprefix, const char *xname
extern int do_jffs2_setxattr(struct inode *inode, int xprefix, const char *xname,
const char *buffer, size_t size, int flags);

extern struct xattr_handler *jffs2_xattr_handlers[];
extern struct xattr_handler jffs2_user_xattr_handler;
extern struct xattr_handler jffs2_trusted_xattr_handler;
extern const struct xattr_handler *jffs2_xattr_handlers[];
extern const struct xattr_handler jffs2_user_xattr_handler;
extern const struct xattr_handler jffs2_trusted_xattr_handler;

extern ssize_t jffs2_listxattr(struct dentry *, char *, size_t);
#define jffs2_getxattr generic_getxattr
Expand All @@ -122,7 +122,7 @@ extern ssize_t jffs2_listxattr(struct dentry *, char *, size_t);

#ifdef CONFIG_JFFS2_FS_SECURITY
extern int jffs2_init_security(struct inode *inode, struct inode *dir);
extern struct xattr_handler jffs2_security_xattr_handler;
extern const struct xattr_handler jffs2_security_xattr_handler;
#else
#define jffs2_init_security(inode,dir) (0)
#endif /* CONFIG_JFFS2_FS_SECURITY */
Expand Down
2 changes: 1 addition & 1 deletion fs/jffs2/xattr_trusted.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static size_t jffs2_trusted_listxattr(struct dentry *dentry, char *list,
return retlen;
}

struct xattr_handler jffs2_trusted_xattr_handler = {
const struct xattr_handler jffs2_trusted_xattr_handler = {
.prefix = XATTR_TRUSTED_PREFIX,
.list = jffs2_trusted_listxattr,
.set = jffs2_trusted_setxattr,
Expand Down
2 changes: 1 addition & 1 deletion fs/jffs2/xattr_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static size_t jffs2_user_listxattr(struct dentry *dentry, char *list,
return retlen;
}

struct xattr_handler jffs2_user_xattr_handler = {
const struct xattr_handler jffs2_user_xattr_handler = {
.prefix = XATTR_USER_PREFIX,
.list = jffs2_user_listxattr,
.set = jffs2_user_setxattr,
Expand Down

0 comments on commit 365f0cb

Please sign in to comment.