Skip to content

Commit

Permalink
[SCSI] sas_ata: Don't copy aic94xx's sactive to ata_port
Browse files Browse the repository at this point in the history
Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it
no longer makes any sense to copy the sactive field in the STP response
to ata_port->sactive, as that will confuse libata.  Also, libata seems
to be capable of managing sactive on its own.

The attached patch gets rid of one of the causes of the BUG messages in
ata_qc_new, and seems to work without problems on an IBM x206m.

Signed-off-by: Darrick J. Wong <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
  • Loading branch information
Darrick J. Wong authored and James Bottomley committed Jul 18, 2007
1 parent 1c50dc8 commit 3869159
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/scsi/libsas/sas_ata.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ static void sas_ata_task_done(struct sas_task *task)
dev->sata_dev.sstatus = resp->sstatus;
dev->sata_dev.serror = resp->serror;
dev->sata_dev.scontrol = resp->scontrol;
dev->sata_dev.ap->sactive = resp->sactive;
} else if (stat->stat != SAM_STAT_GOOD) {
ac = sas_to_ata_err(stat);
if (ac) {
Expand Down

0 comments on commit 3869159

Please sign in to comment.