Skip to content

Commit

Permalink
blk-mq: don't bounce by default
Browse files Browse the repository at this point in the history
For historical reasons we default to bouncing highmem pages for all block
queues.  But the blk-mq drivers are easy to audit to ensure that we don't
need this - scsi and mtip32xx set explicit limits and everyone else doesn't
have any particular ones.

Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Christoph Hellwig authored and axboe committed Jun 27, 2017
1 parent 0b0bcac commit 46685d1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions block/blk-mq.c
Original file line number Diff line number Diff line change
Expand Up @@ -2349,11 +2349,6 @@ struct request_queue *blk_mq_init_allocated_queue(struct blk_mq_tag_set *set,

blk_queue_make_request(q, blk_mq_make_request);

/*
* by default assume old behaviour and bounce for any highmem page
*/
blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);

/*
* Do this after blk_queue_make_request() overrides it...
*/
Expand Down
3 changes: 0 additions & 3 deletions drivers/block/virtio_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -720,9 +720,6 @@ static int virtblk_probe(struct virtio_device *vdev)
/* We can handle whatever the host told us to handle. */
blk_queue_max_segments(q, vblk->sg_elems-2);

/* No need to bounce any requests */
blk_queue_bounce_limit(q, BLK_BOUNCE_ANY);

/* No real sector limit. */
blk_queue_max_hw_sectors(q, -1U);

Expand Down
3 changes: 0 additions & 3 deletions drivers/block/xen-blkfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -953,9 +953,6 @@ static void blkif_set_queue_limits(struct blkfront_info *info)

/* Make sure buffer addresses are sector-aligned. */
blk_queue_dma_alignment(rq, 511);

/* Make sure we don't use bounce buffers. */
blk_queue_bounce_limit(rq, BLK_BOUNCE_ANY);
}

static int xlvbd_init_blk_queue(struct gendisk *gd, u16 sector_size,
Expand Down

0 comments on commit 46685d1

Please sign in to comment.