Skip to content

Commit

Permalink
tracing: Remove double-underscore naming in syscall trigger invocations
Browse files Browse the repository at this point in the history
There's no reason to use double-underscores for any variable name in
ftrace_syscall_enter()/exit(), since those functions aren't generated
and there's no need to avoid namespace collisions as with the event
macros, which is where the original invocation code came from.

Link: http://lkml.kernel.org/r/0b489c9d1f7ee315cff60fa0e4c2b433ade8ae0d.1389036657.git.tom.zanussi@linux.intel.com

Signed-off-by: Tom Zanussi <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
tzanussi authored and rostedt committed Jan 6, 2014
1 parent 0641d36 commit 4bf0566
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions kernel/trace/trace_syscalls.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ static void ftrace_syscall_enter(void *data, struct pt_regs *regs, long id)
struct syscall_trace_enter *entry;
struct syscall_metadata *sys_data;
struct ring_buffer_event *event;
enum event_trigger_type __tt = ETT_NONE;
enum event_trigger_type tt = ETT_NONE;
struct ring_buffer *buffer;
unsigned long irq_flags;
unsigned long eflags;
Expand Down Expand Up @@ -352,15 +352,15 @@ static void ftrace_syscall_enter(void *data, struct pt_regs *regs, long id)
syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);

if (eflags & FTRACE_EVENT_FL_TRIGGER_COND)
__tt = event_triggers_call(ftrace_file, entry);
tt = event_triggers_call(ftrace_file, entry);

if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
ring_buffer_discard_commit(buffer, event);
else if (!filter_check_discard(ftrace_file, entry, buffer, event))
trace_current_buffer_unlock_commit(buffer, event,
irq_flags, pc);
if (__tt)
event_triggers_post_call(ftrace_file, __tt);
if (tt)
event_triggers_post_call(ftrace_file, tt);
}

static void ftrace_syscall_exit(void *data, struct pt_regs *regs, long ret)
Expand All @@ -370,7 +370,7 @@ static void ftrace_syscall_exit(void *data, struct pt_regs *regs, long ret)
struct syscall_trace_exit *entry;
struct syscall_metadata *sys_data;
struct ring_buffer_event *event;
enum event_trigger_type __tt = ETT_NONE;
enum event_trigger_type tt = ETT_NONE;
struct ring_buffer *buffer;
unsigned long irq_flags;
unsigned long eflags;
Expand Down Expand Up @@ -414,15 +414,15 @@ static void ftrace_syscall_exit(void *data, struct pt_regs *regs, long ret)
entry->ret = syscall_get_return_value(current, regs);

if (eflags & FTRACE_EVENT_FL_TRIGGER_COND)
__tt = event_triggers_call(ftrace_file, entry);
tt = event_triggers_call(ftrace_file, entry);

if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
ring_buffer_discard_commit(buffer, event);
else if (!filter_check_discard(ftrace_file, entry, buffer, event))
trace_current_buffer_unlock_commit(buffer, event,
irq_flags, pc);
if (__tt)
event_triggers_post_call(ftrace_file, __tt);
if (tt)
event_triggers_post_call(ftrace_file, tt);
}

static int reg_event_syscall_enter(struct ftrace_event_file *file,
Expand Down

0 comments on commit 4bf0566

Please sign in to comment.