Skip to content

Commit

Permalink
lib: notifier-error-inject: no need to check return value of debugfs_…
Browse files Browse the repository at this point in the history
…create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Jul 3, 2019
1 parent 1be5147 commit 56f3364
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions lib/notifier-error-inject.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,33 +59,22 @@ struct dentry *notifier_err_inject_init(const char *name, struct dentry *parent,
err_inject->nb.priority = priority;

dir = debugfs_create_dir(name, parent);
if (!dir)
return ERR_PTR(-ENOMEM);

actions_dir = debugfs_create_dir("actions", dir);
if (!actions_dir)
goto fail;

for (action = err_inject->actions; action->name; action++) {
struct dentry *action_dir;

action_dir = debugfs_create_dir(action->name, actions_dir);
if (!action_dir)
goto fail;

/*
* Create debugfs r/w file containing action->error. If
* notifier call chain is called with action->val, it will
* fail with the error code
*/
if (!debugfs_create_errno("error", mode, action_dir,
&action->error))
goto fail;
debugfs_create_errno("error", mode, action_dir, &action->error);
}
return dir;
fail:
debugfs_remove_recursive(dir);
return ERR_PTR(-ENOMEM);
}
EXPORT_SYMBOL_GPL(notifier_err_inject_init);

Expand Down

0 comments on commit 56f3364

Please sign in to comment.