Skip to content

Commit

Permalink
crc32: optimize inner loop
Browse files Browse the repository at this point in the history
Taking a pointer reference to each row in the crc table matrix, one can
reduce the inner loop with a few insn's

Signed-off-by: Joakim Tjernlund <[email protected]>
Cc: Bob Pearson <[email protected]>
Cc: Frank Zago <[email protected]>
Cc: Eric Dumazet <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
joakim-tjernlund authored and torvalds committed Jan 11, 2012
1 parent bfcb2cc commit 5742332
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions lib/crc32.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,21 @@ static inline u32
crc32_body(u32 crc, unsigned char const *buf, size_t len, const u32 (*tab)[256])
{
# ifdef __LITTLE_ENDIAN
# define DO_CRC(x) crc = tab[0][(crc ^ (x)) & 255] ^ (crc >> 8)
# define DO_CRC4 crc = tab[3][(crc) & 255] ^ \
tab[2][(crc >> 8) & 255] ^ \
tab[1][(crc >> 16) & 255] ^ \
tab[0][(crc >> 24) & 255]
# define DO_CRC(x) crc = t0[(crc ^ (x)) & 255] ^ (crc >> 8)
# define DO_CRC4 crc = t3[(crc) & 255] ^ \
t2[(crc >> 8) & 255] ^ \
t1[(crc >> 16) & 255] ^ \
t0[(crc >> 24) & 255]
# else
# define DO_CRC(x) crc = tab[0][((crc >> 24) ^ (x)) & 255] ^ (crc << 8)
# define DO_CRC4 crc = tab[0][(crc) & 255] ^ \
tab[1][(crc >> 8) & 255] ^ \
tab[2][(crc >> 16) & 255] ^ \
tab[3][(crc >> 24) & 255]
# define DO_CRC(x) crc = t0[((crc >> 24) ^ (x)) & 255] ^ (crc << 8)
# define DO_CRC4 crc = t0[(crc) & 255] ^ \
t1[(crc >> 8) & 255] ^ \
t2[(crc >> 16) & 255] ^ \
t3[(crc >> 24) & 255]
# endif
const u32 *b;
size_t rem_len;
const u32 *t0=tab[0], *t1=tab[1], *t2=tab[2], *t3=tab[3];

/* Align it */
if (unlikely((long)buf & 3 && len)) {
Expand Down

0 comments on commit 5742332

Please sign in to comment.