Skip to content

Commit

Permalink
pcmcia: sa1100*: remove redundant bvd1/bvd2 setting
Browse files Browse the repository at this point in the history
bvd1 and bvd2 both default to 1 in the generic soc_common code, so
having a driver repeat this is redundant.  Remove it.

Acked-by: Dominik Brodowski <[email protected]>
Signed-off-by: Russell King <[email protected]>
  • Loading branch information
Russell King committed Dec 4, 2018
1 parent f1f05ee commit 57c1cdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/pcmcia/sa1100_simpad.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ simpad_pcmcia_socket_state(struct soc_pcmcia_socket *skt,
{
long cs3reg = simpad_get_cs3_ro();

state->bvd1 = 1; /* Might be cs3reg & PCMCIA_BVD1 */
state->bvd2 = 1; /* Might be cs3reg & PCMCIA_BVD2 */
/* bvd1 might be cs3reg & PCMCIA_BVD1 */
/* bvd2 might be cs3reg & PCMCIA_BVD2 */

if ((cs3reg & (PCMCIA_VS1|PCMCIA_VS2)) ==
(PCMCIA_VS1|PCMCIA_VS2)) {
Expand Down

0 comments on commit 57c1cdc

Please sign in to comment.