Skip to content

Commit

Permalink
pinctrl/at91: Don't provide a default trigger type
Browse files Browse the repository at this point in the history
at91 used to set a default trigger type for GPIO interrupts in
order to cope with the old board files. These days are long gone,
and it all gets probed through DT.

Andras Szemzo reported that the Ethernet device on his board was
bailing to be probed, due to a conflict in interrupt trigger.
Surely enough, this is due to this default trigger still being
present, and turning this into a IRQ_TYPE_NONE fixes the issue.

Reported-by: Andras Szemzo <[email protected]>
Tested-by: Andras Szemzo <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
  • Loading branch information
Marc Zyngier authored and linusw committed Sep 12, 2016
1 parent 66cd89d commit 5803348
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pinctrl/pinctrl-at91.c
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
&gpio_irqchip,
0,
handle_edge_irq,
IRQ_TYPE_EDGE_BOTH);
IRQ_TYPE_NONE);
if (ret) {
dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
at91_gpio->pioc_idx);
Expand Down

0 comments on commit 5803348

Please sign in to comment.