elevator: fix unnecessary put of elevator in failure case

We already checked that e is NULL, so no point in calling elevator_put() to free it. Reported-by: Dan Carpenter <[email protected]> Fixes: dc877dbd088f ("blk-mq-sched: add framework for MQ capable IO schedulers") Signed-off-by: Jens Axboe <[email protected]>
ambv · Jan 19, 2017 · 610d886 · 610d886
1 parent 38dbb7d
commit 610d886
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/block/elevator.c b/block/elevator.c
@@ -230,10 +230,6 @@ int elevator_init(struct request_queue *q, char *name)
 			printk(KERN_ERR
 				"Default I/O scheduler not found. " \
 				"Using noop/none.\n");
-			if (q->mq_ops) {
-				elevator_put(e);
-				return 0;
-			}
 			e = elevator_get("noop", false);
 		}
 	}