Skip to content

Commit

Permalink
crypto: caam - change key gen functions to return signed int
Browse files Browse the repository at this point in the history
commit 2af8f4a "crypto: caam - coccicheck fixes" added error
return values yet neglected to change the type from unsigned.

Signed-off-by: Kim Phillips <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
kimphill authored and herbertx committed Apr 25, 2013
1 parent 87de457 commit 66b3e88
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions drivers/crypto/caam/caamhash.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ static int ahash_set_sh_desc(struct crypto_ahash *ahash)
return 0;
}

static u32 gen_split_hash_key(struct caam_hash_ctx *ctx, const u8 *key_in,
static int gen_split_hash_key(struct caam_hash_ctx *ctx, const u8 *key_in,
u32 keylen)
{
return gen_split_key(ctx->jrdev, ctx->key, ctx->split_key_len,
Expand All @@ -420,7 +420,7 @@ static u32 gen_split_hash_key(struct caam_hash_ctx *ctx, const u8 *key_in,
}

/* Digest hash size if it is too large */
static u32 hash_digest_key(struct caam_hash_ctx *ctx, const u8 *key_in,
static int hash_digest_key(struct caam_hash_ctx *ctx, const u8 *key_in,
u32 *keylen, u8 *key_out, u32 digestsize)
{
struct device *jrdev = ctx->jrdev;
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/caam/key_gen.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Split key generation-----------------------------------------------
[06] 0x64260028 fifostr: class2 mdsplit-jdk len=40
@0xffe04000
*/
u32 gen_split_key(struct device *jrdev, u8 *key_out, int split_key_len,
int gen_split_key(struct device *jrdev, u8 *key_out, int split_key_len,
int split_key_pad_len, const u8 *key_in, u32 keylen,
u32 alg_op)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/caam/key_gen.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ struct split_key_result {

void split_key_done(struct device *dev, u32 *desc, u32 err, void *context);

u32 gen_split_key(struct device *jrdev, u8 *key_out, int split_key_len,
int gen_split_key(struct device *jrdev, u8 *key_out, int split_key_len,
int split_key_pad_len, const u8 *key_in, u32 keylen,
u32 alg_op);

0 comments on commit 66b3e88

Please sign in to comment.