Skip to content

Commit

Permalink
net: small cleanup of lib8390
Browse files Browse the repository at this point in the history
Remove the always true #if 1. Also the unecessary re-test of ei_local->irqlock
and the unreachable printk format string.

Signed-off-by: Nikanth Karthikesan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Nikanth Karthikesan authored and davem330 committed Apr 21, 2010
1 parent 989a297 commit 6846ad2
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/lib8390.c
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,14 @@ static irqreturn_t __ei_interrupt(int irq, void *dev_id)

if (ei_local->irqlock)
{
#if 1 /* This might just be an interrupt for a PCI device sharing this line */
/* The "irqlock" check is only for testing. */
printk(ei_local->irqlock
? "%s: Interrupted while interrupts are masked! isr=%#2x imr=%#2x.\n"
: "%s: Reentering the interrupt handler! isr=%#2x imr=%#2x.\n",
/*
* This might just be an interrupt for a PCI device sharing
* this line
*/
printk("%s: Interrupted while interrupts are masked!"
" isr=%#2x imr=%#2x.\n",
dev->name, ei_inb_p(e8390_base + EN0_ISR),
ei_inb_p(e8390_base + EN0_IMR));
#endif
spin_unlock(&ei_local->page_lock);
return IRQ_NONE;
}
Expand Down

0 comments on commit 6846ad2

Please sign in to comment.