Skip to content

Commit

Permalink
perf arm-spe: augment the data source type with neoverse_spe list
Browse files Browse the repository at this point in the history
When synthesizing event with SPE data source, commit 4e6430c("perf
arm-spe: Use SPE data source for neoverse cores") augment the type with
source information by MIDR. However, is_midr_in_range only compares the
first entry in neoverse_spe.

Change is_midr_in_range to is_midr_in_range_list to traverse the
neoverse_spe array so that all neoverse cores synthesize event with data
source packet.

Fixes: 4e6430c ("perf arm-spe: Use SPE data source for neoverse cores")
Reviewed-by: Ali Saidi <[email protected]>
Reviewed-by: Leo Yan <[email protected]>
Signed-off-by: Jing Zhang <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Ali Saidi <[email protected]>
Cc: German Gomez <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: James Clark <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: John Garry <[email protected]>
Cc: [email protected]
Cc: Mark Rutland <[email protected]>
Cc: Mike Leach <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Shuai Xue <[email protected]>
Cc: Timothy Hayes <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Zhuo Song <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
Jing Zhang authored and acmel committed Sep 28, 2022
1 parent 5064424 commit 74a61d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/arm-spe.c
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ static void arm_spe__synth_data_source_generic(const struct arm_spe_record *reco
static u64 arm_spe__synth_data_source(const struct arm_spe_record *record, u64 midr)
{
union perf_mem_data_src data_src = { 0 };
bool is_neoverse = is_midr_in_range(midr, neoverse_spe);
bool is_neoverse = is_midr_in_range_list(midr, neoverse_spe);

if (record->op == ARM_SPE_LD)
data_src.mem_op = PERF_MEM_OP_LOAD;
Expand Down

0 comments on commit 74a61d5

Please sign in to comment.