Skip to content

Commit

Permalink
tracing: Don't add flag strings when displaying variable references
Browse files Browse the repository at this point in the history
Variable references should never have flags appended when displayed -
prevent that from happening.

Before:

  # cat /sys/kernel/debug/tracing/events/sched/sched_switch/trigger
  hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0.usecs:...

After:

  hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0:...

Link: http://lkml.kernel.org/r/913318a5610ef6b24af2522575f671fa6ee19b6b.1522256721.git.tom.zanussi@linux.intel.com

Signed-off-by: Tom Zanussi <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
  • Loading branch information
tzanussi authored and rostedt committed Apr 6, 2018
1 parent 0ae7961 commit 7669094
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/trace/trace_events_hist.c
Original file line number Diff line number Diff line change
Expand Up @@ -2052,7 +2052,7 @@ static void expr_field_str(struct hist_field *field, char *expr)

strcat(expr, hist_field_name(field, 0));

if (field->flags) {
if (field->flags && !(field->flags & HIST_FIELD_FL_VAR_REF)) {
const char *flags_str = get_hist_field_flags(field);

if (flags_str) {
Expand Down

0 comments on commit 7669094

Please sign in to comment.