Skip to content

Commit

Permalink
ntfs: remove i_version handling
Browse files Browse the repository at this point in the history
NTFS keeps track of the i_version counter here, seemingly for no reason.
It does not set the SB_I_VERSION flag so it'll never be incremented on
write, and it doesn't increment it internally for metadata operations.

Signed-off-by: Jeff Layton <[email protected]>
  • Loading branch information
jtlayton committed Jan 1, 2018
1 parent 8ec426c commit 7a11ac2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
9 changes: 0 additions & 9 deletions fs/ntfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,13 +560,6 @@ static int ntfs_read_locked_inode(struct inode *vi)
ntfs_debug("Entering for i_ino 0x%lx.", vi->i_ino);

/* Setup the generic vfs inode parts now. */

/*
* This is for checking whether an inode has changed w.r.t. a file so
* that the file can be updated if necessary (compare with f_version).
*/
vi->i_version = 1;

vi->i_uid = vol->uid;
vi->i_gid = vol->gid;
vi->i_mode = 0;
Expand Down Expand Up @@ -1240,7 +1233,6 @@ static int ntfs_read_locked_attr_inode(struct inode *base_vi, struct inode *vi)
base_ni = NTFS_I(base_vi);

/* Just mirror the values from the base inode. */
vi->i_version = base_vi->i_version;
vi->i_uid = base_vi->i_uid;
vi->i_gid = base_vi->i_gid;
set_nlink(vi, base_vi->i_nlink);
Expand Down Expand Up @@ -1507,7 +1499,6 @@ static int ntfs_read_locked_index_inode(struct inode *base_vi, struct inode *vi)
ni = NTFS_I(vi);
base_ni = NTFS_I(base_vi);
/* Just mirror the values from the base inode. */
vi->i_version = base_vi->i_version;
vi->i_uid = base_vi->i_uid;
vi->i_gid = base_vi->i_gid;
set_nlink(vi, base_vi->i_nlink);
Expand Down
6 changes: 0 additions & 6 deletions fs/ntfs/mft.c
Original file line number Diff line number Diff line change
Expand Up @@ -2641,12 +2641,6 @@ ntfs_inode *ntfs_mft_record_alloc(ntfs_volume *vol, const int mode,
goto undo_mftbmp_alloc;
}
vi->i_ino = bit;
/*
* This is for checking whether an inode has changed w.r.t. a
* file so that the file can be updated if necessary (compare
* with f_version).
*/
vi->i_version = 1;

/* The owner and group come from the ntfs volume. */
vi->i_uid = vol->uid;
Expand Down

0 comments on commit 7a11ac2

Please sign in to comment.