Skip to content

Commit

Permalink
last_radio_log: switch to proc_create()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Apr 9, 2013
1 parent ee21ed0 commit 8510e30
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions arch/arm/mach-msm/last_radio_log.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,8 @@ extern void *smem_item(unsigned id, unsigned *size);
static ssize_t last_radio_log_read(struct file *file, char __user *buf,
size_t len, loff_t *offset)
{
loff_t pos = *offset;
ssize_t count;

if (pos >= radio_log_size)
return 0;

count = min(len, (size_t)(radio_log_size - pos));
if (copy_to_user(buf, radio_log_base + pos, count)) {
pr_err("%s: copy to user failed\n", __func__);
return -EFAULT;
}

*offset += count;
return count;
return simple_read_from_buffer(buf, len, offset,
radio_log_base, radio_log_size);
}

static struct file_operations last_radio_log_fops = {
Expand All @@ -67,7 +55,8 @@ void msm_init_last_radio_log(struct module *owner)
return;
}

entry = create_proc_entry("last_radio_log", S_IFREG | S_IRUGO, NULL);
entry = proc_create("last_radio_log", S_IRUGO, NULL,
&last_radio_log_fops);
if (!entry) {
pr_err("%s: could not create proc entry for radio log\n",
__func__);
Expand All @@ -77,7 +66,6 @@ void msm_init_last_radio_log(struct module *owner)
pr_err("%s: last radio log is %d bytes long\n", __func__,
radio_log_size);
last_radio_log_fops.owner = owner;
entry->proc_fops = &last_radio_log_fops;
entry->size = radio_log_size;
}
EXPORT_SYMBOL(msm_init_last_radio_log);

0 comments on commit 8510e30

Please sign in to comment.