Skip to content

Commit

Permalink
ide cd: do not set REQ_WRITE on requests.
Browse files Browse the repository at this point in the history
The block layer will set the correct READ/WRITE operation flags/fields
when creating a request, so there is not need for drivers to set the
REQ_WRITE flag.

Signed-off-by: Mike Christie <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Hannes Reinecke <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Mike Christie authored and axboe committed Jun 7, 2016
1 parent 1b9a9ab commit 8e45c6f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/ide/ide-cd_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
layer. the packet must be complete, as we do not
touch it at all. */

if (cgc->data_direction == CGC_DATA_WRITE)
flags |= REQ_WRITE;

if (cgc->sense)
memset(cgc->sense, 0, sizeof(struct request_sense));

Expand Down

0 comments on commit 8e45c6f

Please sign in to comment.