Skip to content

Commit

Permalink
tracing: trace_bprintk() cleanups
Browse files Browse the repository at this point in the history
Impact: cleanup

Remove a few leftovers and clean up the code a bit.

Signed-off-by: Frederic Weisbecker <[email protected]>
Cc: Steven Rostedt <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
Ingo Molnar committed Mar 6, 2009
1 parent 769b044 commit 9de3682
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 17 deletions.
6 changes: 0 additions & 6 deletions kernel/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -2158,12 +2158,6 @@ static noinline struct module *load_module(void __user *umod,
&mod->num_tracepoints);
#endif

#ifdef CONFIG_TRACE_BPRINTK
mod->trace_bprintk_fmt_start = section_objs(hdr, sechdrs, secstrings,
"__trace_bprintk_fmt", sizeof(char *),
&mod->num_trace_bprintk_fmt);
#endif

#ifdef CONFIG_MODVERSIONS
if ((mod->num_syms && !mod->crcs)
|| (mod->num_gpl_syms && !mod->gpl_crcs)
Expand Down
19 changes: 8 additions & 11 deletions kernel/trace/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,11 @@ struct userstack_entry {
*/
struct print_entry {
struct trace_entry ent;
unsigned long ip;
unsigned long ip;
int depth;
const char *fmt;
u32 buf[];
u32 buf[];
};
#ifdef CONFIG_TRACE_BPRINTK
extern int trace_bprintk_enable;
#endif

#define TRACE_OLD_SIZE 88

Expand Down Expand Up @@ -199,7 +196,7 @@ struct kmemtrace_free_entry {
* trace_flag_type is an enumeration that holds different
* states when a trace occurs. These are:
* IRQS_OFF - interrupts were disabled
* IRQS_NOSUPPORT - arch does not support irqs_disabled_flags
* IRQS_NOSUPPORT - arch does not support irqs_disabled_flags
* NEED_RESCED - reschedule is requested
* HARDIRQ - inside an interrupt handler
* SOFTIRQ - inside a softirq handler
Expand Down Expand Up @@ -302,7 +299,7 @@ extern void __ftrace_bad_type(void);
IF_ASSIGN(var, ent, struct ftrace_graph_ret_entry, \
TRACE_GRAPH_RET); \
IF_ASSIGN(var, ent, struct hw_branch_entry, TRACE_HW_BRANCHES);\
IF_ASSIGN(var, ent, struct trace_power, TRACE_POWER); \
IF_ASSIGN(var, ent, struct trace_power, TRACE_POWER); \
IF_ASSIGN(var, ent, struct kmemtrace_alloc_entry, \
TRACE_KMEM_ALLOC); \
IF_ASSIGN(var, ent, struct kmemtrace_free_entry, \
Expand All @@ -325,8 +322,8 @@ enum print_line_t {
* flags value in struct tracer_flags.
*/
struct tracer_opt {
const char *name; /* Will appear on the trace_options file */
u32 bit; /* Mask assigned in val field in tracer_flags */
const char *name; /* Will appear on the trace_options file */
u32 bit; /* Mask assigned in val field in tracer_flags */
};

/*
Expand All @@ -335,7 +332,7 @@ struct tracer_opt {
*/
struct tracer_flags {
u32 val;
struct tracer_opt *opts;
struct tracer_opt *opts;
};

/* Makes more easy to define a tracer opt */
Expand Down Expand Up @@ -390,7 +387,7 @@ struct tracer {
int (*set_flag)(u32 old_flags, u32 bit, int set);
struct tracer *next;
int print_max;
struct tracer_flags *flags;
struct tracer_flags *flags;
struct tracer_stat *stats;
};

Expand Down

0 comments on commit 9de3682

Please sign in to comment.