sample-trace-array: Remove trace_array 'sample-instance'

Remove trace_array 'sample-instance' if kthread_run fails in sample_trace_array_init(). Link: https://lkml.kernel.org/r/[email protected] Cc: [email protected] Fixes: 89ed424 ("tracing: Sample module to demonstrate kernel access to Ftrace instances.") Reviewed-by: Divya Indi <[email protected]> Signed-off-by: Kefeng Wang <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
ambv · Jun 17, 2020 · 9fbc01c · 9fbc01c
1 parent e9b7b1c
commit 9fbc01c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/samples/ftrace/sample-trace-array.c b/samples/ftrace/sample-trace-array.c
@@ -115,8 +115,12 @@ static int __init sample_trace_array_init(void)
 	trace_printk_init_buffers();
 
 	simple_tsk = kthread_run(simple_thread, NULL, "sample-instance");
-	if (IS_ERR(simple_tsk))
+	if (IS_ERR(simple_tsk)) {
+		trace_array_put(tr);
+		trace_array_destroy(tr);
 		return -1;
+	}
+
 	return 0;
 }