Skip to content

Commit

Permalink
net: phy: check for implementation of both callbacks in phy_drv_suppo…
Browse files Browse the repository at this point in the history
…rts_irq

Now that the icplus driver has been fixed all PHY drivers supporting
interrupts have both callbacks (config_intr and ack_interrupt)
implemented - as it should be. Therefore phy_drv_supports_irq()
can be changed now to check for both callbacks being implemented.

Signed-off-by: Heiner Kallweit <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
hkallweit authored and davem330 committed Nov 17, 2018
1 parent 6551971 commit a21ff3c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/phy/phy_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -2122,7 +2122,7 @@ static void of_set_phy_eee_broken(struct phy_device *phydev)

static bool phy_drv_supports_irq(struct phy_driver *phydrv)
{
return phydrv->config_intr || phydrv->ack_interrupt;
return phydrv->config_intr && phydrv->ack_interrupt;
}

/**
Expand Down

0 comments on commit a21ff3c

Please sign in to comment.