Skip to content

Commit

Permalink
drm/i915/icl: Drop spurious register read from icl_dbuf_slices_update
Browse files Browse the repository at this point in the history
Register DBUF_CTL_S2 is read and it's value is not used. As
there is no explanation why we should prime the hardware with
read, remove it as spurious.

Fixes: aa9664f ("drm/i915/icl: Enable 2nd DBuf slice only when needed")
Cc: Mahesh Kumar <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Signed-off-by: Mika Kuoppala <[email protected]>
Reviewed-by: Imre Deak <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit 8577c31)
Signed-off-by: Joonas Lahtinen <[email protected]>
  • Loading branch information
mikuint authored and jlahtine-intel committed Nov 14, 2018
1 parent 6a67a20 commit a226123
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpu/drm/i915/intel_runtime_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -3176,8 +3176,7 @@ static u8 intel_dbuf_max_slices(struct drm_i915_private *dev_priv)
void icl_dbuf_slices_update(struct drm_i915_private *dev_priv,
u8 req_slices)
{
u8 hw_enabled_slices = dev_priv->wm.skl_hw.ddb.enabled_slices;
u32 val;
const u8 hw_enabled_slices = dev_priv->wm.skl_hw.ddb.enabled_slices;
bool ret;

if (req_slices > intel_dbuf_max_slices(dev_priv)) {
Expand All @@ -3188,7 +3187,6 @@ void icl_dbuf_slices_update(struct drm_i915_private *dev_priv,
if (req_slices == hw_enabled_slices || req_slices == 0)
return;

val = I915_READ(DBUF_CTL_S2);
if (req_slices > hw_enabled_slices)
ret = intel_dbuf_slice_set(dev_priv, DBUF_CTL_S2, true);
else
Expand Down

0 comments on commit a226123

Please sign in to comment.