Skip to content

Commit

Permalink
xen-netfront: remove leftover call to xennet_tx_buf_gc()
Browse files Browse the repository at this point in the history
In talk_to_netback(), called earlier from xennet_connect(), queues and
shared rings were just re-initialized, so all this function call could
result in is setting ->broken (again) right away in case any unconsumed
responses were found.

Signed-off-by: Jan Beulich <[email protected]>
Signed-off-by: Paolo Abeni <[email protected]>
  • Loading branch information
jbeulich authored and Paolo Abeni committed Jul 14, 2022
1 parent 9b63367 commit ad39baf
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/xen-netfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -2464,10 +2464,6 @@ static int xennet_connect(struct net_device *dev)
if (queue->tx_irq != queue->rx_irq)
notify_remote_via_irq(queue->rx_irq);

spin_lock_irq(&queue->tx_lock);
xennet_tx_buf_gc(queue);
spin_unlock_irq(&queue->tx_lock);

spin_lock_bh(&queue->rx_lock);
xennet_alloc_rx_buffers(queue);
spin_unlock_bh(&queue->rx_lock);
Expand Down

0 comments on commit ad39baf

Please sign in to comment.