Skip to content

Commit

Permalink
drm/msm: Fix 0xfffflub in "Refactor address space initialization"
Browse files Browse the repository at this point in the history
This week I started seeing GPU crashes on my DragonBoard 845c
which I narrowed down to being caused by commit ccac7ce
("drm/msm: Refactor address space initialization").

Looking through the patch, Jordan and I couldn't find anything
obviously wrong, so I ended up breaking that change up into a
number of smaller logical steps so I could figure out which part
was causing the trouble.

Ends up, visually counting 'f's is hard, esp across a number
of lines:
  0xfffffff != 0xffffffff

This patch corrects the end value we pass in to
msm_gem_address_space_create() in
adreno_iommu_create_address_space() so that it matches the value
used before the problematic patch landed.

With this change, I no longer see the GPU crashes that were
affecting me.

Cc: Shawn Guo <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Jordan Crouse <[email protected]>
Cc: [email protected]
Fixes: ccac7ce ("drm/msm: Refactor address space initialization")
Signed-off-by: John Stultz <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
  • Loading branch information
johnstultz-work authored and robclark committed Jun 13, 2020
1 parent 2e7ec6b commit bc8bd54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/msm/adreno/adreno_gpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,
struct msm_gem_address_space *aspace;

aspace = msm_gem_address_space_create(mmu, "gpu", SZ_16M,
0xfffffff);
0xffffffff);

if (IS_ERR(aspace) && !IS_ERR(mmu))
mmu->funcs->destroy(mmu);
Expand Down

0 comments on commit bc8bd54

Please sign in to comment.