Skip to content

Commit

Permalink
coccinelle: api: extend spatch for dropping unnecessary owner
Browse files Browse the repository at this point in the history
i2c_add_driver (through i2c_register_driver) sets the owner field so we
can drop it also from i2c drivers, just like from platform drivers.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
  • Loading branch information
krzk authored and Michal Marek committed Aug 19, 2015
1 parent bf7b005 commit bec8a5a
Showing 1 changed file with 73 additions and 0 deletions.
73 changes: 73 additions & 0 deletions scripts/coccinelle/api/platform_no_drv_owner.cocci
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ virtual org
virtual report

@match1@
declarer name module_i2c_driver;
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
identifier __driver;
@@
(
module_i2c_driver(__driver);
|
module_platform_driver(__driver);
|
module_platform_driver_probe(__driver, ...);
Expand All @@ -28,6 +31,15 @@ identifier match1.__driver;
}
};

@fix1_i2c depends on match1 && patch && !context && !org && !report@
identifier match1.__driver;
@@
static struct i2c_driver __driver = {
.driver = {
- .owner = THIS_MODULE,
}
};

@match2@
identifier __driver;
@@
Expand All @@ -37,6 +49,8 @@ identifier __driver;
platform_driver_probe(&__driver, ...)
|
platform_create_bundle(&__driver, ...)
|
i2c_add_driver(&__driver)
)

@fix2 depends on match2 && patch && !context && !org && !report@
Expand All @@ -48,6 +62,15 @@ identifier match2.__driver;
}
};

@fix2_i2c depends on match2 && patch && !context && !org && !report@
identifier match2.__driver;
@@
static struct i2c_driver __driver = {
.driver = {
- .owner = THIS_MODULE,
}
};

// ----------------------------------------------------------------------------

@fix1_context depends on match1 && !patch && (context || org || report)@
Expand All @@ -61,6 +84,17 @@ position j0;
}
};

@fix1_i2c_context depends on match1 && !patch && (context || org || report)@
identifier match1.__driver;
position j0;
@@

static struct i2c_driver __driver = {
.driver = {
* .owner@j0 = THIS_MODULE,
}
};

@fix2_context depends on match2 && !patch && (context || org || report)@
identifier match2.__driver;
position j0;
Expand All @@ -72,6 +106,17 @@ position j0;
}
};

@fix2_i2c_context depends on match2 && !patch && (context || org || report)@
identifier match2.__driver;
position j0;
@@

static struct i2c_driver __driver = {
.driver = {
* .owner@j0 = THIS_MODULE,
}
};

// ----------------------------------------------------------------------------

@script:python fix1_org depends on org@
Expand All @@ -81,13 +126,27 @@ j0 << fix1_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
@script:python fix1_i2c_org depends on org@
j0 << fix1_i2c_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
@script:python fix2_org depends on org@
j0 << fix2_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
@script:python fix2_i2c_org depends on org@
j0 << fix2_i2c_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.org.print_todo(j0[0], msg)
// ----------------------------------------------------------------------------
@script:python fix1_report depends on report@
Expand All @@ -97,10 +156,24 @@ j0 << fix1_context.j0;
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
@script:python fix1_i2c_report depends on report@
j0 << fix1_i2c_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
@script:python fix2_report depends on report@
j0 << fix2_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)
@script:python fix2_i2c_report depends on report@
j0 << fix2_i2c_context.j0;
@@
msg = "No need to set .owner here. The core will do it."
coccilib.report.print_report(j0[0], msg)

0 comments on commit bec8a5a

Please sign in to comment.