Skip to content

Commit

Permalink
Revert "net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_…
Browse files Browse the repository at this point in the history
…xfrm"

This reverts commit f10e001.

This commit was just wrong. It caused a lot of
syzbot warnings, so just revert it.

Signed-off-by: Steffen Klassert <[email protected]>
  • Loading branch information
klassert committed Mar 20, 2019
1 parent 6ee02a5 commit bfc01dd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 24 deletions.
2 changes: 1 addition & 1 deletion include/net/netns/xfrm.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ struct netns_xfrm {
struct list_head inexact_bins;


struct sock __rcu *nlsk;
struct sock *nlsk;
struct sock *nlsk_stash;

u32 sysctl_aevent_etime;
Expand Down
30 changes: 7 additions & 23 deletions net/xfrm/xfrm_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -1071,22 +1071,6 @@ static inline int xfrm_nlmsg_multicast(struct net *net, struct sk_buff *skb,
return nlmsg_multicast(nlsk, skb, pid, group, GFP_ATOMIC);
}

/* A similar wrapper like xfrm_nlmsg_multicast checking that nlsk is still
* available.
*/
static inline int xfrm_nlmsg_unicast(struct net *net, struct sk_buff *skb,
u32 pid)
{
struct sock *nlsk = rcu_dereference(net->xfrm.nlsk);

if (!nlsk) {
kfree_skb(skb);
return -EPIPE;
}

return nlmsg_unicast(nlsk, skb, pid);
}

static inline unsigned int xfrm_spdinfo_msgsize(void)
{
return NLMSG_ALIGN(4)
Expand Down Expand Up @@ -1211,7 +1195,7 @@ static int xfrm_get_spdinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
err = build_spdinfo(r_skb, net, sportid, seq, *flags);
BUG_ON(err < 0);

return xfrm_nlmsg_unicast(net, r_skb, sportid);
return nlmsg_unicast(net->xfrm.nlsk, r_skb, sportid);
}

static inline unsigned int xfrm_sadinfo_msgsize(void)
Expand Down Expand Up @@ -1270,7 +1254,7 @@ static int xfrm_get_sadinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
err = build_sadinfo(r_skb, net, sportid, seq, *flags);
BUG_ON(err < 0);

return xfrm_nlmsg_unicast(net, r_skb, sportid);
return nlmsg_unicast(net->xfrm.nlsk, r_skb, sportid);
}

static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
Expand All @@ -1290,7 +1274,7 @@ static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
if (IS_ERR(resp_skb)) {
err = PTR_ERR(resp_skb);
} else {
err = xfrm_nlmsg_unicast(net, resp_skb, NETLINK_CB(skb).portid);
err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).portid);
}
xfrm_state_put(x);
out_noput:
Expand Down Expand Up @@ -1353,7 +1337,7 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
goto out;
}

err = xfrm_nlmsg_unicast(net, resp_skb, NETLINK_CB(skb).portid);
err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).portid);

out:
xfrm_state_put(x);
Expand Down Expand Up @@ -1919,8 +1903,8 @@ static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
if (IS_ERR(resp_skb)) {
err = PTR_ERR(resp_skb);
} else {
err = xfrm_nlmsg_unicast(net, resp_skb,
NETLINK_CB(skb).portid);
err = nlmsg_unicast(net->xfrm.nlsk, resp_skb,
NETLINK_CB(skb).portid);
}
} else {
xfrm_audit_policy_delete(xp, err ? 0 : 1, true);
Expand Down Expand Up @@ -2078,7 +2062,7 @@ static int xfrm_get_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
err = build_aevent(r_skb, x, &c);
BUG_ON(err < 0);

err = xfrm_nlmsg_unicast(net, r_skb, NETLINK_CB(skb).portid);
err = nlmsg_unicast(net->xfrm.nlsk, r_skb, NETLINK_CB(skb).portid);
spin_unlock_bh(&x->lock);
xfrm_state_put(x);
return err;
Expand Down

0 comments on commit bfc01dd

Please sign in to comment.