Skip to content

Commit

Permalink
cfq: reorder cfq_queue removing padding on 64bit
Browse files Browse the repository at this point in the history
This removes 8 bytes of padding from struct cfq_queue on 64 bit builds,
shrinking it's size to 256 bytes, so fitting into 1 fewer cachelines and
allowing 1 more object/slab in it's kmem_cache.

Signed-off-by: Richard Kennedy <[email protected]>
Reviewed-by: Jeff Moyer <[email protected]>
----
patch against 2.6.33-rc8
tested on x86_64 AMDX2
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Richard Kennedy authored and Jens Axboe committed Feb 22, 2010
1 parent f11cbd7 commit c4081ba
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,11 @@ struct cfq_queue {
/* time when queue got scheduled in to dispatch first request. */
unsigned long dispatch_start;
unsigned int allocated_slice;
unsigned int slice_dispatch;
/* time when first request from queue completed and slice started. */
unsigned long slice_start;
unsigned long slice_end;
long slice_resid;
unsigned int slice_dispatch;

/* pending metadata requests */
int meta_pending;
Expand All @@ -130,13 +130,13 @@ struct cfq_queue {
unsigned short ioprio, org_ioprio;
unsigned short ioprio_class, org_ioprio_class;

pid_t pid;

unsigned int seek_samples;
u64 seek_total;
sector_t seek_mean;
sector_t last_request_pos;

pid_t pid;

struct cfq_rb_root *service_tree;
struct cfq_queue *new_cfqq;
struct cfq_group *cfqg;
Expand Down

0 comments on commit c4081ba

Please sign in to comment.