ALSA: PCM: Fix possible memory leaks in the error path

When the first page allocation failed for sgbuf, it leaks the records that have been formerly allocated. Signed-off-by: Takashi Iwai <[email protected]>
ambv · Aug 3, 2012 · c810f90 · c810f90
1 parent ac190c7
commit c810f90
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sound/core/sgbuf.c b/sound/core/sgbuf.c
@@ -101,7 +101,7 @@ void *snd_malloc_sgbuf_pages(struct device *device,
 		if (snd_dma_alloc_pages_fallback(SNDRV_DMA_TYPE_DEV, device,
 						 chunk, &tmpb) < 0) {
 			if (!sgbuf->pages)
-				return NULL;
+				goto _failed;
 			if (!res_size)
 				goto _failed;
 			size = sgbuf->pages * PAGE_SIZE;