Skip to content

Commit

Permalink
fs/romfs/super.c: use pr_fmt in logging
Browse files Browse the repository at this point in the history
- Remove "Error" in format logging (already in pr_ level)

- Use modulename in pr_fmt instead of ROMFS: in each pr_ callsites.

Signed-off-by: Fabian Frederick <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Fabian Frederick authored and torvalds committed Aug 8, 2014
1 parent 3d79d31 commit ca9e536
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions fs/romfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
* 2 of the Licence, or (at your option) any later version.
*/

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/module.h>
#include <linux/string.h>
#include <linux/fs.h>
Expand Down Expand Up @@ -380,7 +382,7 @@ static struct inode *romfs_iget(struct super_block *sb, unsigned long pos)
eio:
ret = -EIO;
error:
pr_err("ROMFS: read error for inode 0x%lx\n", pos);
pr_err("read error for inode 0x%lx\n", pos);
return ERR_PTR(ret);
}

Expand Down Expand Up @@ -513,17 +515,16 @@ static int romfs_fill_super(struct super_block *sb, void *data, int silent)
}

if (romfs_checksum(rsb, min_t(size_t, img_size, 512))) {
pr_err("ROMFS: bad initial checksum on dev %s.\n",
sb->s_id);
pr_err("bad initial checksum on dev %s.\n", sb->s_id);
goto error_rsb_inval;
}

storage = sb->s_mtd ? "MTD" : "the block layer";

len = strnlen(rsb->name, ROMFS_MAXFN);
if (!silent)
pr_notice("ROMFS: Mounting image '%*.*s' through %s\n",
(unsigned) len, (unsigned) len, rsb->name, storage);
pr_notice("Mounting image '%*.*s' through %s\n",
(unsigned) len, (unsigned) len, rsb->name, storage);

kfree(rsb);
rsb = NULL;
Expand Down Expand Up @@ -622,12 +623,12 @@ static int __init init_romfs_fs(void)
romfs_i_init_once);

if (!romfs_inode_cachep) {
pr_err("ROMFS error: Failed to initialise inode cache\n");
pr_err("Failed to initialise inode cache\n");
return -ENOMEM;
}
ret = register_filesystem(&romfs_fs_type);
if (ret) {
pr_err("ROMFS error: Failed to register filesystem\n");
pr_err("Failed to register filesystem\n");
goto error_register;
}
return 0;
Expand Down

0 comments on commit ca9e536

Please sign in to comment.