selinux: Fix an uninitialized variable bug

We removed this initialization as a cleanup but it is probably required. The concern is that "nel" can be zero. I'm not an expert on SELinux code but I think it looks possible to write an SELinux policy which triggers this bug. GCC doesn't catch this, but my static checker does. Fixes: 9c312e7 ("selinux: Delete an unnecessary variable initialisation in range_read()") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Stephen Smalley <[email protected]> Signed-off-by: Paul Moore <[email protected]>
ambv · Mar 31, 2017 · cae303d · cae303d
1 parent 342e915
commit cae303d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
@@ -1832,7 +1832,7 @@ u32 string_to_av_perm(struct policydb *p, u16 tclass, const char *name)
 
 static int range_read(struct policydb *p, void *fp)
 {
-	struct range_trans *rt;
+	struct range_trans *rt = NULL;
 	struct mls_range *r = NULL;
 	int i, rc;
 	__le32 buf[2];