kmsg: /dev/kmsg - properly return possible copy_from_user() failure

Reported-by: Andrew Morton <[email protected]> Signed-off-by: Kay Sievers <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
ambv · Jul 31, 2012 · cdf5344 · cdf5344
1 parent 5353cf0
commit cdf5344
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/kernel/printk.c b/kernel/printk.c
@@ -389,8 +389,10 @@ static ssize_t devkmsg_writev(struct kiocb *iocb, const struct iovec *iv,
 
 	line = buf;
 	for (i = 0; i < count; i++) {
-		if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len))
+		if (copy_from_user(line, iv[i].iov_base, iv[i].iov_len)) {
+			ret = -EFAULT;
 			goto out;
+		}
 		line += iv[i].iov_len;
 	}