Skip to content

Commit

Permalink
dnotify: do not bother to lock entry->lock when reading mask
Browse files Browse the repository at this point in the history
entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.

Signed-off-by: Eric Paris <[email protected]>
  • Loading branch information
eparis committed Jun 11, 2009
1 parent 5ac697b commit ce61856
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/notify/dnotify/dnotify.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group,
if (!entry)
return false;

spin_lock(&entry->lock);
send = (mask & entry->mask);
spin_unlock(&entry->lock);

fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */

return send;
Expand Down

0 comments on commit ce61856

Please sign in to comment.