NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check if the neighbour pointer is valid before dereferencing it. Signed-off-by: Ralf Baechle <[email protected]> Tested-by: Bernard Pidoux <[email protected]> Cc: [email protected] #2.6.11+ Signed-off-by: David S. Miller <[email protected]>
ambv · Jun 23, 2015 · d496f78 · d496f78
1 parent dfea2aa
commit d496f78
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
@@ -192,7 +192,8 @@ static void rose_kill_by_device(struct net_device *dev)
 
 		if (rose->device == dev) {
 			rose_disconnect(s, ENETUNREACH, ROSE_OUT_OF_ORDER, 0);
-			rose->neighbour->use--;
+			if (rose->neighbour)
+				rose->neighbour->use--;
 			rose->device = NULL;
 		}
 	}