Skip to content

Commit

Permalink
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel…
Browse files Browse the repository at this point in the history
…/git/jikos/apm

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/apm:
  apm-emulation: apm_mutex breaks ACK; remove it
  APM: take over maintainership
  • Loading branch information
torvalds committed May 23, 2011
2 parents 710421c + fda5fe1 commit e0c6b8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 3 additions & 2 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -548,10 +548,11 @@ S: Maintained
F: sound/aoa/

APM DRIVER
L: [email protected]
S: Orphan
M: Jiri Kosina <[email protected]>
S: Odd fixes
F: arch/x86/kernel/apm_32.c
F: include/linux/apm_bios.h
F: drivers/char/apm-emulation.c

APPLE BCM5974 MULTITOUCH DRIVER
M: Henrik Rydberg <[email protected]>
Expand Down
5 changes: 0 additions & 5 deletions drivers/char/apm-emulation.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ struct apm_user {
/*
* Local variables
*/
static DEFINE_MUTEX(apm_mutex);
static atomic_t suspend_acks_pending = ATOMIC_INIT(0);
static atomic_t userspace_notification_inhibit = ATOMIC_INIT(0);
static int apm_disabled;
Expand Down Expand Up @@ -275,7 +274,6 @@ apm_ioctl(struct file *filp, u_int cmd, u_long arg)
if (!as->suser || !as->writer)
return -EPERM;

mutex_lock(&apm_mutex);
switch (cmd) {
case APM_IOC_SUSPEND:
mutex_lock(&state_lock);
Expand Down Expand Up @@ -336,7 +334,6 @@ apm_ioctl(struct file *filp, u_int cmd, u_long arg)
mutex_unlock(&state_lock);
break;
}
mutex_unlock(&apm_mutex);

return err;
}
Expand Down Expand Up @@ -371,7 +368,6 @@ static int apm_open(struct inode * inode, struct file * filp)
{
struct apm_user *as;

mutex_lock(&apm_mutex);
as = kzalloc(sizeof(*as), GFP_KERNEL);
if (as) {
/*
Expand All @@ -391,7 +387,6 @@ static int apm_open(struct inode * inode, struct file * filp)

filp->private_data = as;
}
mutex_unlock(&apm_mutex);

return as ? 0 : -ENOMEM;
}
Expand Down

0 comments on commit e0c6b8a

Please sign in to comment.