Skip to content

Commit

Permalink
ALSA: fireworks: fix asymmetric API call at unit removal
Browse files Browse the repository at this point in the history
ALSA fireworks driver has a bug not to call an API to destroy
'cmp_connection' structure for input direction. Currently this causes no
issues because it just destroys 'mutex' structure, while it's better to
fix it for future work.

Fix: d23c2cc ("ALSA: fireworks/bebob/dice/oxfw: allow stream destructor after releasing runtime")
Signed-off-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
takaswie authored and tiwai committed Jan 3, 2017
1 parent 0c744ea commit e2eb31d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/firewire/fireworks/fireworks_stream.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ destroy_stream(struct snd_efw *efw, struct amdtp_stream *stream)
conn = &efw->in_conn;

amdtp_stream_destroy(stream);
cmp_connection_destroy(&efw->out_conn);
cmp_connection_destroy(conn);
}

static int
Expand Down

0 comments on commit e2eb31d

Please sign in to comment.