Skip to content

Commit

Permalink
selftests: net: af_unix: Fix makefile to use TEST_GEN_PROGS
Browse files Browse the repository at this point in the history
Makefile uses TEST_PROGS instead of TEST_GEN_PROGS to define
executables. TEST_PROGS is for shell scripts that need to be
installed and run by the common lib.mk framework. The common
framework doesn't touch TEST_PROGS when it does build and clean.

As a result "make kselftest-clean" and "make clean" fail to remove
executables. Run and install work because the common framework runs
and installs TEST_PROGS. Build works because the Makefile defines
"all" rule which is unnecessary if TEST_GEN_PROGS is used.

Use TEST_GEN_PROGS so the common framework can handle build/run/
install/clean properly.

Signed-off-by: Shuah Khan <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
shuahkh authored and davem330 committed Sep 19, 2021
1 parent 72a3c58 commit e30cd81
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tools/testing/selftests/net/af_unix/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
##TEST_GEN_FILES := test_unix_oob
TEST_PROGS := test_unix_oob
TEST_GEN_PROGS := test_unix_oob
include ../../lib.mk

all: $(TEST_PROGS)

0 comments on commit e30cd81

Please sign in to comment.