Skip to content

Commit

Permalink
ipv6: fix exthdrs offload registration in out_rt path
Browse files Browse the repository at this point in the history
We previously register IPPROTO_ROUTING offload under inet6_add_offload(),
but in error path, we try to unregister it with inet_del_offload(). This
doesn't seem correct, it should actually be inet6_del_offload(), also
ipv6_exthdrs_offload_exit() from that commit seems rather incorrect (it
also uses rthdr_offload twice), but it got removed entirely later on.

Fixes: 3336288 ("ipv6: Switch to using new offload infrastructure.")
Signed-off-by: Daniel Borkmann <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
borkmann authored and davem330 committed Sep 2, 2015
1 parent 210c34d commit e41b0be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv6/exthdrs_offload.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ int __init ipv6_exthdrs_offload_init(void)
return ret;

out_rt:
inet_del_offload(&rthdr_offload, IPPROTO_ROUTING);
inet6_del_offload(&rthdr_offload, IPPROTO_ROUTING);
goto out;
}

0 comments on commit e41b0be

Please sign in to comment.