Skip to content

Commit

Permalink
Merge tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm
Browse files Browse the repository at this point in the history
Pull ARM fixes from Russell King:

 - fix CPU topology setup for SCHED_MC case

 - fix VDSO regression

* tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm:
  ARM: 8947/1: Fix __arch_get_hw_counter() access to CNTVCT
  ARM: 8943/1: Fix topology setup in case of CPU hotplug for CONFIG_SCHED_MC
  • Loading branch information
torvalds committed Dec 7, 2019
2 parents 347f56f + 04bb964 commit eea2d5d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
3 changes: 3 additions & 0 deletions arch/arm/include/asm/vdso/gettimeofday.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ static __always_inline u64 __arch_get_hw_counter(int clock_mode)
#ifdef CONFIG_ARM_ARCH_TIMER
u64 cycle_now;

if (!clock_mode)
return -EINVAL;

isb();
cycle_now = read_sysreg(CNTVCT);

Expand Down
4 changes: 4 additions & 0 deletions arch/arm/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ int __cpu_disable(void)
if (ret)
return ret;

#ifdef CONFIG_GENERIC_ARCH_TOPOLOGY
remove_cpu_topology(cpu);
#endif

/*
* Take this CPU offline. Once we clear this, we can't return,
* and we must not schedule until we're ready to give up the cpu.
Expand Down
10 changes: 5 additions & 5 deletions arch/arm/kernel/topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,8 @@ void store_cpu_topology(unsigned int cpuid)
struct cpu_topology *cpuid_topo = &cpu_topology[cpuid];
unsigned int mpidr;

/* If the cpu topology has been already set, just return */
if (cpuid_topo->core_id != -1)
return;
if (cpuid_topo->package_id != -1)
goto topology_populated;

mpidr = read_cpuid_mpidr();

Expand Down Expand Up @@ -231,14 +230,15 @@ void store_cpu_topology(unsigned int cpuid)
cpuid_topo->package_id = -1;
}

update_siblings_masks(cpuid);

update_cpu_capacity(cpuid);

pr_info("CPU%u: thread %d, cpu %d, socket %d, mpidr %x\n",
cpuid, cpu_topology[cpuid].thread_id,
cpu_topology[cpuid].core_id,
cpu_topology[cpuid].package_id, mpidr);

topology_populated:
update_siblings_masks(cpuid);
}

static inline int cpu_corepower_flags(void)
Expand Down

0 comments on commit eea2d5d

Please sign in to comment.