Skip to content

Commit

Permalink
parisc: Fix kernel crash with reversed copy_from_user()
Browse files Browse the repository at this point in the history
The kernel module testcase (lib/test_user_copy.c) exhibited a kernel
crash on parisc if the parameters for copy_from_user were reversed
("illegal reversed copy_to_user" testcase).

Fix this potential crash by checking the fault handler if the faulting
address is in the exception table.

Signed-off-by: Helge Deller <[email protected]>
Cc: [email protected]
Cc: Kees Cook <[email protected]>
  • Loading branch information
hdeller committed Apr 8, 2016
1 parent e389302 commit ef72f31
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/parisc/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,9 @@ void notrace handle_interruption(int code, struct pt_regs *regs)

if (fault_space == 0 && !faulthandler_disabled())
{
/* Clean up and return if in exception table. */
if (fixup_exception(regs))
return;
pdc_chassis_send_status(PDC_CHASSIS_DIRECT_PANIC);
parisc_terminate("Kernel Fault", regs, code, fault_address);
}
Expand Down

0 comments on commit ef72f31

Please sign in to comment.