Skip to content

Commit

Permalink
serial: core: delete .set_wake() callback
Browse files Browse the repository at this point in the history
This deletes the .set_wake() callback in the struct uart_ops.
Apparently this has been unused since pre-git times. In the
old-2.6-bkcvs it is deleted as part of a changeset removing
the PM_SET_WAKEUP from pm_request_t which is since also deleted
from the kernel.

The apropriate way to set wakeups in the kernel is to have a
code snippet like this in .suspend() or .runtime_suspend()
callbacks:

static int foo_suspend(struct device *dev)
{
	if (device_may_wakeup(dev)) {
		/* Enable wakeups, set internal states */
	}
}

This specific callback is not coming back.

Cc: Rafael J. Wysocki <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Kevin Hilman <[email protected]>
Cc: Dmitry Artamonow <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
linusw authored and gregkh committed Oct 16, 2013
1 parent 3592501 commit fa2b5ea
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions Documentation/serial/driver
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,6 @@ hardware.
Locking: none.
Interrupts: caller dependent.

set_wake(port,state)
Enable/disable power management wakeup on serial activity. Not
currently implemented.

type(port)
Return a pointer to a string constant describing the specified
port, or return NULL, in which case the string 'unknown' is
Expand Down
1 change: 0 additions & 1 deletion include/linux/serial_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ struct uart_ops {
void (*set_ldisc)(struct uart_port *, int new);
void (*pm)(struct uart_port *, unsigned int state,
unsigned int oldstate);
int (*set_wake)(struct uart_port *, unsigned int state);

/*
* Return a string describing the type of the port
Expand Down

0 comments on commit fa2b5ea

Please sign in to comment.