Skip to content

Commit

Permalink
Merge branch 'vfs-for-3.16' of git://git.infradead.org/users/hch/vfs
Browse files Browse the repository at this point in the history
Pull vfs fixes from Christoph Hellwig:
 "A vfsmount leak fix, and a compile warning fix"

* 'vfs-for-3.16' of git://git.infradead.org/users/hch/vfs:
  fs: umount on symlink leaks mnt count
  direct-io: fix uninitialized warning in do_direct_IO()
  • Loading branch information
torvalds committed Jul 27, 2014
2 parents 2bdb5eb + 295dc39 commit fbf08ef
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
14 changes: 7 additions & 7 deletions fs/direct-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,8 @@ static inline int dio_refill_pages(struct dio *dio, struct dio_submit *sdio)
* L1 cache.
*/
static inline struct page *dio_get_page(struct dio *dio,
struct dio_submit *sdio, size_t *from, size_t *to)
struct dio_submit *sdio)
{
int n;
if (dio_pages_present(sdio) == 0) {
int ret;

Expand All @@ -209,10 +208,7 @@ static inline struct page *dio_get_page(struct dio *dio,
return ERR_PTR(ret);
BUG_ON(dio_pages_present(sdio) == 0);
}
n = sdio->head++;
*from = n ? 0 : sdio->from;
*to = (n == sdio->tail - 1) ? sdio->to : PAGE_SIZE;
return dio->pages[n];
return dio->pages[sdio->head];
}

/**
Expand Down Expand Up @@ -911,11 +907,15 @@ static int do_direct_IO(struct dio *dio, struct dio_submit *sdio,
while (sdio->block_in_file < sdio->final_block_in_request) {
struct page *page;
size_t from, to;
page = dio_get_page(dio, sdio, &from, &to);

page = dio_get_page(dio, sdio);
if (IS_ERR(page)) {
ret = PTR_ERR(page);
goto out;
}
from = sdio->head ? 0 : sdio->from;
to = (sdio->head == sdio->tail - 1) ? sdio->to : PAGE_SIZE;
sdio->head++;

while (from < to) {
unsigned this_chunk_bytes; /* # of bytes mapped */
Expand Down
3 changes: 2 additions & 1 deletion fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -2256,9 +2256,10 @@ mountpoint_last(struct nameidata *nd, struct path *path)
goto out;
}
path->dentry = dentry;
path->mnt = mntget(nd->path.mnt);
path->mnt = nd->path.mnt;
if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW))
return 1;
mntget(path->mnt);
follow_mount(path);
error = 0;
out:
Expand Down

0 comments on commit fbf08ef

Please sign in to comment.