mac80211: fix the skb cloned check in the tx path

Using skb_header_cloned to check if it's safe to write to the skb is not enough - mac80211 also touches the tailroom of the skb. Initially this check was only used to increase a counter, however this commit changed the code to also skip skb data reallocation if no extra head/tailroom was needed: commit 4cd06a3 mac80211: skip unnecessary pskb_expand_head calls It added a regression at least with iwl3945, which is fixed by this patch. Reported-by: Dmitry Torokhov <[email protected]> Signed-off-by: Felix Fietkau <[email protected]> Tested-by: Dmitry Torokhov <[email protected]> Signed-off-by: John W. Linville <[email protected]>
ambv · Feb 7, 2011 · fc7c976 · fc7c976
1 parent 3dd823e
commit fc7c976
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
@@ -1547,7 +1547,7 @@ static int ieee80211_skb_resize(struct ieee80211_local *local,
 		skb_orphan(skb);
 	}
 
-	if (skb_header_cloned(skb))
+	if (skb_cloned(skb))
 		I802_DEBUG_INC(local->tx_expand_skb_head_cloned);
 	else if (head_need || tail_need)
 		I802_DEBUG_INC(local->tx_expand_skb_head);