Skip to content

Commit

Permalink
net: dsa: microchip: ksz8795: really set the correct number of ports
Browse files Browse the repository at this point in the history
The KSZ9477 and KSZ8795 use the port_cnt field differently: For the
KSZ9477, it includes the CPU port(s), while for the KSZ8795, it doesn't.

It would be a good cleanup to make the handling of both drivers match,
but as a first step, fix the recently broken assignment of num_ports in
the KSZ8795 driver (which completely broke probing, as the CPU port
index was always failing the num_ports check).

Fixes: af199a1 ("net: dsa: microchip: set the correct number of ports")
Signed-off-by: Matthias Schiffer <[email protected]>
Reviewed-by: Codrin Ciubotariu <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
tq-schifferm authored and davem330 committed Sep 17, 2020
1 parent 34beb21 commit fd944dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dsa/microchip/ksz8795.c
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ static int ksz8795_switch_init(struct ksz_device *dev)
}

/* set the real number of ports */
dev->ds->num_ports = dev->port_cnt;
dev->ds->num_ports = dev->port_cnt + 1;

return 0;
}
Expand Down

0 comments on commit fd944dc

Please sign in to comment.